[PATCH] D91428: Add support for multiple program address spaces
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 12:21:19 PST 2020
jrtc27 added a comment.
Currently `P0-P1` is valid and results in the program address space being 1, but this patch changes the semantics of that. How sure are you that nothing will break? I do not like the idea of reusing existing valid syntax to mean something else; if you want to introduce some notion of secondary program address spaces then the syntax should be different.
However, I don't understand why this is needed; can you not just change your `call void %ref()` to `call addrspace(1) void %ref()`? That gets parsed and type-checked
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits