[PATCH] D90059: [ms] [llvm-ml] Support command-line defines
Eric Astor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 12:20:29 PST 2020
epastor added inline comments.
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6920
+ Var.Redefinable = true;
+ Var.IsText = true;
> masm doesn't do it, but I think we should diag on redefinitions in -D flags, at least if the redefinition has a different value. that's likely always a bug in the build system invoking us.
I'm not sure there's a clean way to do this that isn't an error, and I'd like to maintain compatibility with ml64.exe on this. If you think it's worth special-casing this to plumb a warning through, we can do that... but I'm not convinced it's a good idea.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits