[PATCH] D89736: [ms] [llvm-ml] Implement the expression expansion operator

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 12:08:15 PST 2020

epastor marked 2 inline comments as done.
epastor added inline comments.

Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3297
+    return parseAngleBracketString(Data);
+  case AsmToken::Identifier: {
+    StringRef ID;
thakis wrote:
> This branch seems unrelated to this patch (?)
This is part of unifying handling for all textitem forms, including textmacros.

Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:5554
+  SMLoc EndLoc = getTok().getLoc();
+  if (getTok().isNot(AsmToken::EndOfStatement) && parseTextItem(Value))
+    return Error(EndLoc,
thakis wrote:
> also looks unrelated (?)
This fixes an unrelated bug discovered in the course of testing this commit - before, there was no error for a failure to parse the textitem.

Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6035
+            "expected text item parameter for 'elseifidn' directive");
+      else
+        return TokError(
thakis wrote:
> thakis wrote:
> > llvm code style says no else after return; lhs code was better
> (this is still not addressed)
Addressed now; thanks!

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list