[PATCH] D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount.

[Janek van Oirschot via Phabricator via llvm-commits]

JanekvO added inline comments.


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:388
+  ExitCount = SE.getAddExpr(ExitCount, SE.getOne(ExitCount->getType()));
   if (!ExitCount->getType()->isPointerTy() &&
       ExitCount->getType() != CountType)
----------------
samparker wrote:
> Could you also double check that this PointerTy check is necessary, it seems a little odd to me but I don't know much about the PPC implementation.
I did a quick check and removed the PointerTy check and it seems all tests still run fine. However, I don't know enough about either PPC nor scalar evolution to confidently remove the check. Intuitively, it sounds unlikely for `getExitCount` to return a pointer type but I'm not sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91724/new/

https://reviews.llvm.org/D91724