[PATCH] D91435: [AMDGPU] Split edge to make si_if dominate end_cf

[Alexander via Phabricator via llvm-commits]

alex-t marked an inline comment as done.
alex-t added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp:317
+  if (!isa<UndefValue>(Exec) && !isa<UnreachableInst>(FirstInsertionPt)) {
+    Instruction *ExecDef = dyn_cast<Instruction>(Exec);
+    BasicBlock *DefBB = ExecDef->getParent();
----------------
arsenm wrote:
> This should be a cast since it's unchecked
Yes. "Exec" producer is always an Instruction. So cast is okay.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91435/new/

https://reviews.llvm.org/D91435