[PATCH] D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle

Mon Nov 23 06:09:55 PST 2020

thakis added a comment.

Thanks! I'll land this and follow up on eventual maskray feedback in a separate change. (Original comment was 24 min after upload, I replied well within west coast working hours, so maybe it's fine as-is.)

================
Comment at: lld/MachO/Options.td:1109
      Group<grp_undocumented>;
 def demangle : Flag<["-"], "demangle">,
+     HelpText<"Demangle symbol names in diagnostics">;
----------------
hans wrote:
> thakis wrote:
> > hans wrote:
> > > All options seem to belong to a Group and also be ordered in the .td file according to group. Now that it's no longer in grp_undocumented, maybe it should move into another group?
> > Options without explicit end up in "OPTIONS:" in `lld -flavor darwinnew --help`, which seems the correct group for this flag. Do you think it should be in a different group? A new group?
> Are there any other options that are not in Group?
> Perhaps grp_rare would fit? It seems like a bit of a catch-all, e.g. -v is there.
> 
> In any case, the .td file seems quite strictly organized around these groups, so if we take this out of grp_undocumented I think definition should at least move out of this part of the file -- either to a different group, or somewhere around the top/bottom if it doesn't get any group.
`--color-diagnostics` and `--help`, but these aren't in ld64 (and the former was added by me). But making these flags show up in "OPTIONS" seems correct to me. I guess I'll see what int3 says on https://reviews.llvm.org/D91894 for fatal_warnings and then I can follow up here to make demangle do the same thing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91884/new/

https://reviews.llvm.org/D91884