[PATCH] D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 05:31:24 PST 2020

simoll added inline comments.

Comment at: llvm/test/CodeGen/VE/Vector/vec_add.ll:76
+; Function Attrs: nounwind
kaz7 wrote:
> kaz7 wrote:
> > Removing regression test cases like `add_iv_v256i64()` means that you need to implement `iv` test cases for all vector instructions when you implement a FoldImmediate for all vector instructions.  Just want to make sure that you intend it.
> > Just want to make sure that you intend it.
> I meant that "Just want to make clear what you intend to do."
Not testing the immediate special case here is intentional since there neither is a code path to test - i think the test-cases-with-immediate should be added here with the patch for immediate folding pass.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list