[PATCH] D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 added inline comments.


================
Comment at: llvm/test/CodeGen/VE/Vector/vec_add.ll:76
+}
+
+; Function Attrs: nounwind
----------------
kaz7 wrote:
> Removing regression test cases like `add_iv_v256i64()` means that you need to implement `iv` test cases for all vector instructions when you implement a FoldImmediate for all vector instructions.  Just want to make sure that you intend it.
> Just want to make sure that you intend it.

I meant that "Just want to make clear what you intend to do."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91802/new/

https://reviews.llvm.org/D91802