[PATCH] D88962: [SVE] Add support for scalable vectors with vectorize.scalable.enable loop attribute

Mon Nov 23 03:43:55 PST 2020

david-arm marked an inline comment as done.
david-arm added a comment.

Hi @fhahn @SjoerdMeijer @paulwalker-arm, are you happy with the patch now? The implementation on the LLVM IR side of things is independent of the clang pragma patch. For the clang patch I intend to write a proposal to the mailing list for changing the vectorize_width #pragma. @fhahn would you be happy with removing the "Request changes" cross?

================
Comment at: llvm/docs/LangRef.rst:5930

+'``llvm.loop.vectorize.scalable.enable``' Metadata
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
----------------
SjoerdMeijer wrote:
> I am wondering if we need to describe if and how this interacts with `llvm.loop.vectorize.enable`?
I adapted this documentation from the vectorize.predicate.enable case above, which didn't discuss the interaction with vectorize.enable so I just thought I didn't need to here either. I've made it clear that this flag only has any effect if vectorisation is already enabled (although this could be through simply building with -O2).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88962/new/

https://reviews.llvm.org/D88962