[PATCH] D90341: Use deref facts derived from minimum object size of allocations
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 03:23:02 PST 2020
nikic added a comment.
The logic here looks sound to me. Structurally, I would suggest integrating this with the getPointerDereferenceableBytes() check above, as you are currently duplicating the logic around it. Basically extract the current getPointerDereferenceableBytes() call into a static function/lambda, and add the handling for the allocated object size in there, the remaining logic (including the non-null check and the alignment check) will be shared.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90341/new/
https://reviews.llvm.org/D90341
More information about the llvm-commits
mailing list