[PATCH] D90103: Add OpenMP for optimization
Abid via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 02:59:44 PST 2020
abidmalikwaterloo marked an inline comment as done.
abidmalikwaterloo added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:71
+ /// Keeps map of __kmpc_static_init4 and its __kmpc_static_fini calls for each OpenMP for loop
+ std::map<CallInst *, CallInst *> call_init_fini_mapping;
+ std::map<CallInst *, BasicBlock*> call_basicblock_mapping;
----------------
sstefan1 wrote:
> Maybe consider using LLVM's ADTs.? Same goes for the rest of the patch.
>
> Also, you should follow the [[ https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly | coding style ]]
Can you elaborate? std::map is llvm ADT.
https://llvm.org/docs/ProgrammersManual.html#map
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90103/new/
https://reviews.llvm.org/D90103
More information about the llvm-commits
mailing list