[PATCH] D88382: [VPlan] Turn VPReductionRecipe into a VPValue

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7959
       WidenRecipe->getParent()->insert(RedRecipe, WidenRecipe->getIterator());
       WidenRecipe->eraseFromParent();
 
----------------
Now that both VPWidenREcipe and VPRedcutionRecipe are VPValues, we have to update all users of WidenRecipe with RedRecipe.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7967
                "Expected to replace a VPWidenSC");
         CompareRecipe->eraseFromParent();
       }
----------------
We need to update the users of VPWidenRecipe's VPValue or assert that there are none.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88382/new/

https://reviews.llvm.org/D88382