[PATCH] D91943: [llvm-readelf/obj] - Fix the possible crash when dumping group sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 02:03:51 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/groups.test:391
+## We set the content of the string table to '0061626300' ('\0abc\0') to fixup the size of the string table.
+## It makes easier the task of testing boundary conditions.
+# RUN: yaml2obj %s -DSTRTABCONTENT="0061626300" -DSYM1STNAME=4 -DSYM2STNAME=5 -o %t.signame.o
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91943/new/

https://reviews.llvm.org/D91943



More information about the llvm-commits mailing list