[PATCH] D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 01:32:24 PST 2020


grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/groups.test:186
+## In the first case we link the group section to the section with index 255, which does not exist.
+## We check that the warning is reported when we are unable to locate the symbol table.
+## In the second case we link the SHT_GROUP section to itself. This documents that we don't check the
----------------
jhenderson wrote:
> jhenderson wrote:
> > 
> Ping this?
Will fix. Sorry!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91867/new/

https://reviews.llvm.org/D91867



More information about the llvm-commits mailing list