[PATCH] D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3572
+template <class ELFT>
+static StringRef getSectionNameForError(const ELFFile<ELFT> &Obj,
+                                        const typename ELFT::Shdr &Sec,
----------------
jhenderson wrote:
> I don't like this function name. It implies it is solely for use by errors, which isn't the case. How about `getSectionNameOrFallback`?
Done. 2 more possible names probably are: `getSectionNameOrWarn` or `tryGetSectionName`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91867/new/

https://reviews.llvm.org/D91867