[PATCH] D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with the suggestion.



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:294
+  if (Opts.UseDIA) {
+    errs() << "Warning: DIA not available; using native PDB reader.\n ";
+    Opts.UseDIA = false;
----------------
Use `WithColor::defaultWarningHandler` instead and don't end the message with '.' (see the [[ https://llvm.org/docs/CodingStandards.html#error-and-warning-messages | coding guidelines ]]).

(I'm aware that llvm-symbolizer isn't consistent in this area, but we can work on improving it gradually)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91814/new/

https://reviews.llvm.org/D91814