[PATCH] D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

In D91767#2410454 <https://reviews.llvm.org/D91767#2410454>, @kuhar wrote:

> In D91767#2410450 <https://reviews.llvm.org/D91767#2410450>, @mkazantsev wrote:
>
>> You can find the planned user in dependencies stack: https://reviews.llvm.org/D90456
>>
>> I need the common dom to find the latest context where we can prove predicate so that it's also true for all given instructions.
>
> What do you think about defining and implementing `bool dominates(Inst, Inst)` at the same time (or before) `findNCDInst`?

It will have a signature clash with existing `dominates(def, use)`. For that, we first need to rename existing `dominates` (including all its users across the code) into something like `defUseAvailable`, and only then implement this. It's a massive refactoring of whole DomTree which I definitely don't want to be blocked on. As you see, as set of changes is currently waiting for this patch.

We can make this, but separately, as follow-up, after the changes are unblocked, if it makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91767/new/

https://reviews.llvm.org/D91767