[PATCH] D91339: [X86] Include %rip for 32-bit RIP-relative relocs for x32

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added inline comments.


================
Comment at: llvm/test/CodeGen/X86/pic.ll:25
+; CHECK-I686:	ret
+; CHECK-DAG-X32:	movl	dst at GOTPCREL(%rip),
+; CHECK-DAG-X32:	movl	ptr at GOTPCREL(%rip),
----------------
pengfei wrote:
> hvdijk wrote:
> > pengfei wrote:
> > > Sorry for not finding it in time.
> > > The prefix `CHECK-DAG-X32` seems not been used.
> > Good spot! I meant `CHECK-X32-DAG` here, and with that, the test still passes. Should I submit that fix as a standalone diff for new review?
> FileCheck doesn't check unused prefix for now. I'm not sure. Maybe you can fix it in the patch you fixing builtbot fail.
Sure, I've added it there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91339/new/

https://reviews.llvm.org/D91339