[PATCH] D90564: [VPlan] Make VPRecipeBase inherit from VPDef.

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 22 05:33:07 PST 2020


gilr added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:113
+    return getVPValue();
   if (auto *V = dyn_cast<VPInstruction>(this))
     return V;
----------------
IIUC this is still necessary since VPInstruction doesn't register itself as a VPValue in its VPDef (ownership issue?). Does this mean that using the VPDef::defined_values() API won't work when VPInstructions are involved?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90564/new/

https://reviews.llvm.org/D90564



More information about the llvm-commits mailing list