[PATCH] D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:832
 //       collapse and ordered
 void OmpAttributeVisitor::PrivatizeAssociatedLoopIndex(
     const parser::OpenMPLoopConstruct &x) {
----------------
yhegde wrote:
> kiranchandramohan wrote:
> > Nit: rename to PrivatizeLoopIndexAndCheckLoopLevel or a better name.
> > Nit: rename to PrivatizeLoopIndexAndCheckLoopLevel or a better name.
> 
> Thank you very much @kiranchandramohan and @clementval for all the review comments.
> Shall I change the name of the function to CheckClauseAssocLoopIndexandLoopLevel ?
> 
> Thank you once again.
This is fine. Please go ahead and submit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89860/new/

https://reviews.llvm.org/D89860