[PATCH] D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

This seems to have broken some tests on our Mac bots:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863040226745741728/+/steps/package_clang/0/stdout

  FAIL: Builtins-x86_64-darwin :: truncsfhf2_test.c (195 of 208)
  ******************** TEST 'Builtins-x86_64-darwin :: truncsfhf2_test.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';       /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/./bin/clang   -gline-tables-only  -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.10 -isysroot /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -DCOMPILER_RT_HAS_FLOAT16  -fno-builtin -I /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/builtins -nodefaultlibs /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/truncsfhf2_test.c /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/./lib/clang/12.0.0/lib/darwin/libclang_rt.osx.a  -lSystem -o /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/projects/compiler-rt/test/builtins/Unit/X86_64DarwinConfig/Output/truncsfhf2_test.c.tmp &&  /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/projects/compiler-rt/test/builtins/Unit/X86_64DarwinConfig/Output/truncsfhf2_test.c.tmp
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  In file included from /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/truncsfhf2_test.c:6:
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:16:15: error: _Float16 is not supported on this target
  static inline TYPE_FP16 fromRep16(uint16_t x)
                ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:19:5: error: _Float16 is not supported on this target
      TYPE_FP16 ret;
      ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:51:32: error: _Float16 is not supported on this target
  static inline uint16_t toRep16(TYPE_FP16 x)
                                 ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:85:34: error: _Float16 is not supported on this target
  static inline int compareResultH(TYPE_FP16 result,
                                   ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:220:15: error: _Float16 is not supported on this target
  static inline TYPE_FP16 makeQNaN16(void)
                ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:242:15: error: _Float16 is not supported on this target
  static inline TYPE_FP16 makeNaN16(uint16_t rand)
                ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:264:15: error: _Float16 is not supported on this target
  static inline TYPE_FP16 makeInf16(void)
                ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/truncsfhf2_test.c:8:1: error: _Float16 is not supported on this target
  TYPE_FP16 __truncsfhf2(float a);
  ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/truncsfhf2_test.c:12:5: error: _Float16 is not supported on this target
      TYPE_FP16 x = __truncsfhf2(a);
      ^
  /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
  #define TYPE_FP16 _Float16
                    ^
  9 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91733/new/

https://reviews.llvm.org/D91733