[PATCH] D91907: Add missing dependencies, which caused link failure when building with -DBUILD_SHARED_LIBS:BOOL=ON

[Anh Tuyen Tran via Phabricator via llvm-commits]

anhtuyen created this revision.
anhtuyen added reviewers: serge-sans-paille, jsji, nemanjai, bmahjour, etiotto.
Herald added subscribers: llvm-commits, hiraditya, mgorny.
Herald added a project: LLVM.
anhtuyen requested review of this revision.

After the integration of the following commit

  commit 9218ff50f93085d0a16a974db28ca8f14bc66f64
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   Fri Oct 9 18:41:21 2020 +0200
  
      llvmbuildectomy - replace llvm-build by plain cmake
  
      No longer rely on an external tool to build the llvm component layout.
  
      Instead, leverage the existing `add_llvm_componentlibrary` cmake function and
      introduce `add_llvm_component_group` to accurately describe component behavior.
  
      These function store extra properties in the created targets. These properties
      are processed once all components are defined to resolve library dependencies
      and produce the header expected by llvm-config.
  
      Differential Revision: https://reviews.llvm.org/D90848

building llvm with shared libraries will fail due to missing dependencies.

The linker complains that:

  lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Wyvern/SimpleLoopUnrollAndJam.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMAnalysis.so.12git  lib/libLLVMCore.so.12git \
   lib/libLLVMSupport.so.12git  -Wl,-rpath-link,/home/etiotto/Source/wyvern_dev/build_llvm/lib && :
  lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopUtils.cpp.o: In function `llvm::makeFollowupLoopID(llvm::MDNode*, llvm::ArrayRef<llvm::StringRef>, char const*, bool)':
  LoopUtils.cpp:(.text._ZN4llvm18makeFollowupLoopIDEPNS_6MDNodeENS_8ArrayRefINS_9StringRefEEEPKcb+0x198): undefined reference to `llvm::isValueProfMD(llvm::MDNode*, llvm::InstrProfValueKind)'

This patch will add the missing dependencies to resolve the above failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91907

Files:
  llvm/lib/Transforms/Scalar/CMakeLists.txt
  llvm/lib/Transforms/Utils/CMakeLists.txt


Index: llvm/lib/Transforms/Utils/CMakeLists.txt
===================================================================
--- llvm/lib/Transforms/Utils/CMakeLists.txt
+++ llvm/lib/Transforms/Utils/CMakeLists.txt
@@ -82,5 +82,6 @@
   LINK_COMPONENTS
   Analysis
   Core
+  ProfileData
   Support
   )
Index: llvm/lib/Transforms/Scalar/CMakeLists.txt
===================================================================
--- llvm/lib/Transforms/Scalar/CMakeLists.txt
+++ llvm/lib/Transforms/Scalar/CMakeLists.txt
@@ -92,6 +92,7 @@
   Analysis
   Core
   InstCombine
+  ProfileData
   Support
   TransformUtils
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91907.306825.patch
Type: text/x-patch
Size: 605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201121/8b2153e7/attachment.bin>