[PATCH] D91423: [NFC][DebugInfo] Factor LowerDbgDeclare into two functions [1/3]

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

This is fine apart from some nitpicks inside.



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1497
 
+static bool ConvertIndirectDbgIntrinsicToDbgValues(DbgDeclareInst *DII,
+                                                   DIBuilder &DIB) {
----------------
Doxygen comment here to explain what this function does?
Which other indirect intrinsics are there?
I'm not sure if the name indirect captures the intention well unless it's part of a greater plan for the future. Otherwise I would just say DbgDeclare to avoid confusion.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1549
+
 /// LowerDbgDeclare - Lowers llvm.dbg.declare intrinsics into appropriate set
 /// of llvm.dbg.value intrinsics.
----------------
Nit: remove `LowerDbgDeclare -`
Also,  the doxygen comment should be in the header file and only there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91423/new/

https://reviews.llvm.org/D91423