[PATCH] D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/test/ELF/undef.s:88
   call _ZTV3Foo
-  call __Z3fooi
----------------
MaskRay wrote:
> ELF does not demangle `__Z` prefixed symbols. Removal of a test does not seem right.
Yes, but when is this ever going to be hit in practice?

The alternative is to pass an "extra underscore" bit to itaniumDemangle() and set that differently for darwin and linux. That seems like overhead with close to 0 benefit, and `llvm/lib/Demangle/Demangle.cpp` made the same tradeoff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91884/new/

https://reviews.llvm.org/D91884