[PATCH] D91849: [WebAssembly] Factor out WasmTableType in binary format

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Awesome!



================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:600
+        TableType = Table.Type.ElemType;
+        if (Table.SymbolName.empty())
+          Table.SymbolName = Info.Name;
----------------
Looks like you also added support for table names..  Maybe mention that in the description?


================
Comment at: llvm/tools/obj2yaml/wasm2yaml.cpp:237
+          // FIXME: Currently we always output an index of 0 for any imported
+          // table.
+          Im.TableImport = makeTable(0, Import.Table);
----------------
Hmm.. is this true for GlobalImport and EventImport too?   It looks like none of them set `Index`.

It it worth switching `Im.TableImport` to be of type `TypeType` instead of `Table?    Maybe that comes latest when the FIXME is addressed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91849/new/

https://reviews.llvm.org/D91849