[PATCH] D91460: [AsmParser] make .ascii/.asciz/.string support spaces as separators

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/MC/AsmParser/directive_ascii.s:52
+# CHECK: .byte 66
+# CHECK: .byte 0
+# CHECK: .byte 67
----------------
jcai19 wrote:
> jrtc27 wrote:
> > This no longer matches binutils and is the specific part of this patch that has been contentious.
> Do you mean the .asciz test case? I think this is what gnu AS does.
> 
> $ cat test1.s 
> .asciz "A", "B" "C"
> 
> $ gcc test1.s -c -o test1.o
> llvm-readelf --string-dump=.text test1.o
> String dump of section '.text':
> [     0] A
> [     2] B
> [     4] C
> 
> $ cat test2.s 
> asciz "A\0B\0C"
> 
> $ gcc test2.s -c -o test2.o
> llvm-readelf --string-dump=.text test2.o
> String dump of section '.text':
> [     0] A
> [     2] B
> [     4] C
> 
> $ cat test3.s 
> asciz "ABC"
> 
> $ gcc test3.s -c -o test3.o
> llvm-readelf --string-dump=.text test3.o
> String dump of section '.text':
> [     0] ABC
> 
> 
> 
Not any more; see https://reviews.llvm.org/D91460#2400719 above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91460/new/

https://reviews.llvm.org/D91460