[PATCH] D91813: [PGO] verify BFI counts after loading profile data

[Rong Xu via Phabricator via llvm-commits]

xur added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:262
+    "pgo-verify-bfi", cl::init(false), cl::Hidden,
+    cl::desc("Print out non-match BFI counts after setting profile metadata."));
+
----------------
davidxl wrote:
> Add a description here that -Rpass-analysis=PGO is needed for messages.
Sure.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1704
+    ORE.emit([&]() {
+      return OptimizationRemark(DEBUG_TYPE, "bfi-verify", F.getSubprogram(),
+                                &F.getEntryBlock())
----------------
davidxl wrote:
> Remark or RemarkAnalysis?
I thought you suggested Remark. I'm OK either way. 
I will change to RemarkAnalysis.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91813/new/

https://reviews.llvm.org/D91813