[PATCH] D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar requested changes to this revision.
kuhar added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/IR/Dominators.cpp:344
+Instruction *DominatorTree::findNearestCommonDominatorInst(
+    ArrayRef<Instruction *> Insns) const {
+  assert(!Insns.empty() && "Should be at least one instruction!");
----------------
nit: please add some vowels. Why not `Instructions`?


================
Comment at: llvm/lib/IR/Dominators.cpp:373
+  }
+  return CommonDom;
+}
----------------
Maybe assert that `CommDom` actually dominates all `Insns` when `EXPENSIVE_CHECKS` are enabled?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91767/new/

https://reviews.llvm.org/D91767