[PATCH] D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D82363#2405903 <https://reviews.llvm.org/D82363#2405903>, @jmorse wrote:

> @StephenTozer what's the status of the latest discussions on this patch? As far as I understand it:
>
> - DBG_VALUE may go away, but that'll be in another patch,
> - There was some conclusion to whether all DBG_VALUE_LISTs should be stack_values too, can't remember what, on the mailing list,
> - This patch, adding the plumbing for the DBG_VALUE_LIST, would be ready to land.

The decision made on the mailing list was to add a flag to the DBG_VALUE_LIST that acts similar to the directness flag on DBG_VALUE, albeit with a more strictly defined meaning. It still needs to be implemented here, and will be added as part of this patch: it will be easiest if there is a single patch which contains the entire DBG_VALUE_LIST, rather than adding a new instruction and then changing its format in a subsequent patch. Everything else is correct, and the patch that renames DBG_VALUE -> DBG_VALUE_OLD, DBG_VALUE_LIST -> DBG_VALUE can easily be added at the end of this patch stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82363/new/

https://reviews.llvm.org/D82363