[PATCH] D89562: [flang]Add Parser Support for OpenMP Allocate Directive

Irina Dobrescu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 08:13:57 PST 2020


Rin added inline comments.


================
Comment at: flang/include/flang/Parser/parse-tree.h:3625
+  std::tuple<Verbatim, OmpObjectList, OmpClauseList> t;
+};
+
----------------
Rin wrote:
> clementval wrote:
> > Is there a good reason to have separate nodes (`OpenMPDeclarativeAllocate`, `OpenMPExecutableAllocateList`)? Both node have the same content. 
> OpenMPDeclarativeAllocate is part of the Declarative construct, whereas OpenMPExecutableAllocateList is part of the Executable construct. I can't use OpenMPDeclarativeAllocate as an executable construct is expected.
I had the same idea to use the OpenMPDeclarativeAllocate, but failed to find a way to make it work unfortunately :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89562/new/

https://reviews.llvm.org/D89562



More information about the llvm-commits mailing list