[PATCH] D90554: [CostModel] remove cost-kind predicate for intrinsics in basic TTI implementation

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D90554#2407132 <https://reviews.llvm.org/D90554#2407132>, @MaskRay wrote:

> define dso_local void @baz() {
> bb:
>
>   %tmp = call <2 x double> @llvm.experimental.constrained.fadd.v2f64(<2 x double> undef, <2 x double> undef, metadata !"round.dynamic", metadata !"fpexcept.ignore")
>   ret void
>
> }

So to clarify policy, we reverted patches when (1) a test based on an experimental intrinsic was crashing and (2) that crash is easily reproducible independent of this patch as shown here:
7ae346434 <https://reviews.llvm.org/rG7ae346434a5f51b81ebaeeb50bd5d97666ee288b>

I understand that we revert first and ask questions later, but should that be the rule for experimental code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90554/new/

https://reviews.llvm.org/D90554