[PATCH] D91857: [ARM] Remove dead mov's in preheader of tail predicated loops

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 07:06:55 PST 2020


samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:802
+      Ignore.insert(VCTPs.begin(), VCTPs.end());
+      if (TryRemove(Def, RDA, ElementChain, Ignore)) {
+        ToRemove.insert(ElementChain.begin(), ElementChain.end());
----------------
TryRemove is, relatively, robust :) I think you should just be able to pass ToRemove in place of ElementChain here, though I can't immediately remember why that isn't the case for the loop above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91857/new/

https://reviews.llvm.org/D91857



More information about the llvm-commits mailing list