[PATCH] D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner.

Fri Nov 20 06:16:10 PST 2020

yroux accepted this revision.
yroux added a comment.
This revision is now accepted and ready to land.

I think that the previous comments were addressed. LGTM

================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:852

+  if (EnableIROutliner)
+    MPM.add(createIROutlinerPass());
----------------
AndrewLitteken wrote:
> yroux wrote:
> > jroelofs wrote:
> > > Out of curiosity, how did you decide that this was the optimal spot in the pass stack for it?
> > Looking at what was presented by River Riddle back in 2017 and the former proposal of an IR Outlining pass in 2018, there was the notion of early (pre inlining) and late (pre Isel) outlining and the combination of both had better results in what was presented, is it something we can do here ?
> > 
> > I also think that it can be added to late LTO passes
> There isn't any configuration right now for the early/late outlining or some combination of the two, but there's nothing in the current implementation that would be blocking that.  Similarly for LTO passes, there's no real limitation to adding it at that level other.
> 
> Would the former be something that would be needed in this patch? Or could it be extended in a future patch?
Yes sure, it'd be great to have it in a future patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86975/new/

https://reviews.llvm.org/D86975