[PATCH] D91331: Add hook for target to customize different legalization action according to the input type

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

It would appear to me that the only test case changes are that the libcalls were turned into tail calls - but of course my knowledge of X86 and ARM asm is next to zero. Presumably the original lowering didn't set the necessary flags on the call and now the legalizer does so.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:2980
+  llvm_unreachable("Unexpected lowering");
+  return SDValue();
 }
----------------
A return after `llvm_unreachable`? Does the build compiler warn about no return here?


================
Comment at: llvm/test/CodeGen/AArch64/arm64-fp128.ll:7
 
 define fp128 @test_add() {
 ; CHECK-LABEL: test_add:
----------------
These appear to have been turned into tail calls with no stack frame. That seems like a positive sideeffect but an ARM/AArch64 expert should certainly confirm that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91331/new/

https://reviews.llvm.org/D91331