[PATCH] D91848: [AArch64] Enable post RA scheduler for Cortex-R82

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:674
+                               FeaturePostRAScheduler,
+                               FeatureCrypto,
+                               FeatureFuseAES,
----------------
dmgreen wrote:
> If you are adding crypto (which doesn't sound like a bad idea to me), should there be some other tests for that?
> 
> If you want to keep this simple and do that in a separate patch, you could just add -mattr=+crypto to the r82 run line.
I discovered I need crypto otherwise we get "can't match aes intrinsics" for the fuse aes tests.
I was in two minds what to do here: strip out the fuse aes business here and do that separately, or see what you thought about doing it here. :-).
I like keeping things simple.... not sure if adding -mattr=crypto will really improve things for now as I need to follow up to properly fix it.  I.e., I probably need to check more, also clang crypto option passing for the r82 and more tests etc., so let's keep it simple and just do that separately then.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91848/new/

https://reviews.llvm.org/D91848