[PATCH] D91804: [NewPM] Add pipeline EP callback after initial frontend cleanup

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D91804#2407321 <https://reviews.llvm.org/D91804#2407321>, @ychen wrote:

> FWIW, could we keep naming it ModuleOptimizerEarlyEPCallback? That sounds pretty intuitive to me and reminds users of the old name. Is the renaming for using the prefix `Pipeline`?

`ModuleOptimizerEarly` is sort of a relic of the legacy PM. The legacy PassManagerBuilder has a `populateFunctionPassManager()` for cleaning up input IR and `populateModulePassManager()` for the real pipeline, but there's no equivalent of `populateFunctionPassManager()` in the NPM. So the `ModuleOptimizer` part of `ModuleOptimizerEarlyEPCallback` wouldn't make sense IMO.

I will agree that the name I chose could be better named, but still unsure of anything better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91804/new/

https://reviews.llvm.org/D91804