[PATCH] D86490: [CSSPGO] IR intrinsic for pseudo-probe block instrumentation

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 22:03:39 PST 2020


wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2249-2250
   } else {
-    BasicBlock::iterator BI = BB->begin();
-    while (isa<DbgInfoIntrinsic>(BI)) ++BI;
-    if (&*BI != RetI)
+    Instruction *I = BB->getFirstNonPHIOrDbg(true);
+    if (I != RetI)
       return false;
----------------
Nit: 
```
if (BB->getFirstNonPHIOrDbg(true) != RetI)
  return false;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86490/new/

https://reviews.llvm.org/D86490



More information about the llvm-commits mailing list