[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

Do we need to consider FP exceptions in _try block?



================
Comment at: clang/include/clang/Driver/Options.td:886
   HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>;
+def feh_asynch: Flag<["-"], "feh-asynch">, Group<f_Group>,
+  HelpText<"Enable EH Asynchronous exceptions">, Flags<[CC1Option]>;
----------------
It's better to follow alphabetical for it and line 1531.


================
Comment at: clang/lib/CodeGen/CGCleanup.cpp:1287
+      PopCleanupBlock();
+    else
+    {
----------------
Move `{` to the same line with `else` and better to add curly brackets for `PopCleanupBlock();`


================
Comment at: clang/test/CodeGen/windows-seh-EHa-TryInFinally.cpp:1
+// RUN: %clang_cc1 -triple x86_64-windows -feh-asynch -fcxx-exceptions -fexceptions -fms-extensions -x c++ -Wno-implicit-function-declaration -S -emit-llvm %s -o - | FileCheck %s
+
----------------
Should this be a C file? I saw LangRef says they are used for C function.


================
Comment at: llvm/docs/LangRef.rst:11534
+'``llvm.seh.try.begin``' and '``llvm.seh.try.end``' Intrinsics
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
----------------
Keep the same length with above line.


================
Comment at: llvm/docs/LangRef.rst:11560
+'``llvm.seh.scope.begin``' and '``llvm.seh.scope.end``' Intrinsics
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
----------------
Keep the same length with above line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344