[PATCH] D91593: [IndVars] LCSSA Phi users should not prevent widening

[Serguei Katkov via Phabricator via llvm-commits]

skatkov accepted this revision.
skatkov added a comment.

lgtm



================
Comment at: llvm/lib/Transforms/Utils/SimplifyIndVar.cpp:1646
+  for (PHINode *User : LCSSAPhiUsers) {
+    assert(User->getNumOperands() == 1 && "Checked before!");
+    Builder.SetInsertPoint(User);
----------------
I doubt that someone can change the content of this set after creation :)


================
Comment at: llvm/lib/Transforms/Utils/SimplifyIndVar.cpp:1649
+    auto *WidePN =
+        Builder.CreatePHI(WideBO->getType(), 1, User->getName() + "wide");
+    BasicBlock *LoopExitingBlock = User->getParent()->getSinglePredecessor();
----------------
".wide"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91593/new/

https://reviews.llvm.org/D91593