[PATCH] D91467: ADT: Take small enough, trivially copyable T by value in SmallVector

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

> Thanks! Looks in the noise. I guess inline+SROA really does clean it up very consistently :)
>
> I don't have any objections to this patch. (It sounds like this ties into another workstream, so I'll let other folks give the final sign-off)

Thanks for the review!

I'm still a bit concerned about the point Mehdi brought up. I've posted an alternative at https://reviews.llvm.org/D91837 which breaks down the problem in a different way; if that doesn't work out (e.g., lots of perf regressions) I'll circle back here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91467/new/

https://reviews.llvm.org/D91467