[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 16:44:14 PST 2020


myhsu added inline comments.


================
Comment at: llvm/include/llvm/MC/MCExpr.h:202
     VK_PCREL,
+    VK_GOTPC,
     VK_GOTPCREL,
----------------
rengolin wrote:
> Does this get exposed in any way? Would it break a previous enum order?
You're right, I don't think any of the M68k code use it at this time point. Will remove it for now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390



More information about the llvm-commits mailing list