[PATCH] D91460: [AsmParser] make .ascii/.asciz/.string support multiple strings

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/AsmParser/directive_ascii.s:46
 TEST7:
-        .ascii "\x64\Xa6B"
-        .ascii "\xface\x0Fe"
+        .ascii "B", "C"
+
----------------
The test may be a bit too verbose in this way.

One `.ascii "A", "B" "C", "D"` is sufficient for the coverage.


================
Comment at: llvm/test/MC/AsmParser/directive_ascii.s:67
+TEST10:
+        .asciz "B" "C"
+
----------------
`.asciz "A", "B" "C", "D"` should produce `A\0BC\0D\0` as GNU as 2.36 will do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91460/new/

https://reviews.llvm.org/D91460