[PATCH] D91825: [hwasan] Implement error report callback.

[Mitch Phillips via Phabricator via llvm-commits]

hctim added a comment.

In D91825#2406724 <https://reviews.llvm.org/D91825#2406724>, @eugenis wrote:

> You can notice that this change is moving SetAbortMessage call out from under error_message_lock_
> I'm not sure why exactly I'm doing this, other than the fact that ASan does it this way.
> All of this is still under the wider error_report_lock_, so a hwasan error in the callback will result in the "nested bug" message and an immediate exit.

Isn't that why ASan is doing it? HWASan error in the cb if it's still locked would result in deadlock.

Possible to add a test just to double check this? Seems like a plausible scenario to tag-mismatch in the callback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91825/new/

https://reviews.llvm.org/D91825