[PATCH] D91038: [LoopIdiom] Introduce 'left-shift until bittest' idiom

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2059
+                      m_Value(CurrX),
+                      m_PHI(m_Incoming(m_SpecificBB(LoopPreheaderBB),
+                                       m_Value(BaseX)),
----------------
Why are we adding a whole new matcher infrastructure for phis? Why can't we use getIncomingValueForBlock?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91038/new/

https://reviews.llvm.org/D91038