[PATCH] D91786: [GVN] Strengthen the updating of dominated users

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:2670
+  unsigned Count = 0;
+  for (Value::use_iterator UI = From->use_begin(), UE = From->use_end();
+       UI != UE;) {
----------------
can probably use a range for here, too.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:2677
+      continue;
+    for (auto PI = pred_begin(UBB), E = pred_end(UBB); PI != E; ++PI) {
+      bool PredDominated = false;
----------------
can be range based for via `predecessors(UBB)`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91786/new/

https://reviews.llvm.org/D91786