[PATCH] D91043: [DebugInfo] Fix convert-loclist.ll
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 11:38:41 PST 2020
probinson added a comment.
In D91043#2390223 <https://reviews.llvm.org/D91043#2390223>, @dblaikie wrote:
> The fix seems fine to me - but I think there's something that at least I'm not understanding and would like to understand, since it's related to understanding the correctness of this fix: Why are there a bunch of other uses of %llc_dwarf in the DebugInfo/X86 tests - why don't they have the same problem as this test?
I think the first question is rhetorical, but it ensures a DWARF target. The second question is the key: What makes this test special, for @luismarques environment? If you build with just RISC-V as the target, this entire directory should become unsupported. If you have both X86 and RISC-V, then these tests do run, and apparently (mostly) run fine. Why didn't this one?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91043/new/
https://reviews.llvm.org/D91043
More information about the llvm-commits
mailing list