[PATCH] D89723: [CSSPGO][llvm-profgen]Context-sensitive profile data generation

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:214-215
+
+// Class for sample unwinding
+class VirtualUnwinder {
+public:
----------------
This virtual unwinder is not doing the classic unwinding thing. It is walking through the LBR stack of a LBR sample, based on the sample's callstack, and infer the callstack for each address range covered by the LBR sample. The comment can be more clear about it.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:62-70
+  A: (300, 0)
+  B: (0, 100)
+  C: (0, 200)
+
+  respectively. With these points, follwing logic finds two disjoint
+  region of
+
----------------
Why there is region [A, B]: 300, but B: (0, 100) only has 100 sample count?


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:262
+
+static FrameLocation getCallerConext(StringRef CalleeContext,
+                                     StringRef &CallerNameWithContext) {
----------------
Conext --> Context?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89723/new/

https://reviews.llvm.org/D89723