[PATCH] D91670: Fix crash after looking up dwo_id=0 in CU index.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 11:02:00 PST 2020


MaskRay added a comment.

In D91670#2403635 <https://reviews.llvm.org/D91670#2403635>, @jgorbe wrote:

>>> then the check `Rows[H].getSignature() != S` won't fail
>>
>> The condition fails. It should return nullptr but returned a Rows entry.
>
> Yeah, I could have expressed this better in the summary. What I meant with "the check won't fail" was that the check `Rows[H].getSignature() != S` is not enough to cause the lookup to fail and return a nullptr (as it should). I'll fix it in the actual commit message.

You can edit the summary to be synchronized with the commit. If you upload differentials with `arc diff --verbatim` (`--verbatim` allows you to modify the summary while uploading a new patch).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91670/new/

https://reviews.llvm.org/D91670



More information about the llvm-commits mailing list