[PATCH] D91803: [lld] Use -1 as tombstone value for discarded code ranges
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 10:21:35 PST 2020
dblaikie added a comment.
In D91803#2405969 <https://reviews.llvm.org/D91803#2405969>, @MaskRay wrote:
> In D91803#2405939 <https://reviews.llvm.org/D91803#2405939>, @sbc100 wrote:
>
>> Are there no tests that fail under this change? If not, I guess we should add one.
>
>
>
> Failed Tests (3):
> lld :: wasm/debug-removed-fn.ll
> lld :: wasm/debuginfo.test
> lld :: wasm/undefined-weak-call.ll
>
> The change does not seem right. For non-debug sections (when --allow-undefined is set), addend; .debug_ranges/.debug_loc => -2; other .debug_* => -1
+1 to that. Could also use a test case for this new functionality.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91803/new/
https://reviews.llvm.org/D91803
More information about the llvm-commits
mailing list