[PATCH] D91806: [SVE] Remove warnings from release notes example on SVE ACLE.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli created this revision.
fpetrogalli added reviewers: peterwaller-arm, efriedma, paulwalker-arm, joechrisellis, sdesmalen.
Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, lxfind, psnobl, hiraditya, tschuett.
Herald added projects: clang, LLVM.
fpetrogalli requested review of this revision.

The warnings were raised in the method `valueCoversEntireFragment` by
the implicit cast of `TypeSize` to `uint64_t` in the RHS of:

  uint64_t ValueSize = DL.getTypeAllocSizeInBits(ValTy);

The other changes in this patch have been made to update
`valueCoversEntireFragment` to uniformily use `TypeSize` instead of
`uint64_t`. No functional changes are intended for these extra
changes. Assertions have been added to prevent untested codepath.

The change is guarded by:

1. a test that compiles the SVE ACLE example `VLA_add_arrays` in the release note of LLVM 11 at https://releases.llvm.org/11.0.0/tools/clang/docs/ReleaseNotes.html,

2. a test in LLVM that stresses the code path in InstCombiner that triggers the warning.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91806

Files:
  clang/test/CodeGen/aarch64-sve-acle-rel-note.c
  llvm/include/llvm/IR/Instructions.h
  llvm/include/llvm/IR/IntrinsicInst.h
  llvm/lib/IR/Instructions.cpp
  llvm/lib/IR/IntrinsicInst.cpp
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/Utils/Debugify.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/InstCombine/debug-declare-no-warnings-on-scalable-vectors.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91806.306451.patch
Type: text/x-patch
Size: 10946 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201119/0dec6466/attachment.bin>